Skip to content

Conversation

@davidtaikocha
Copy link
Collaborator

@davidtaikocha davidtaikocha commented Jul 27, 2025

Will be safer to merge when taikoxyz/taiko-mono#19783 is merged and released.

@davidtaikocha davidtaikocha marked this pull request as ready for review July 27, 2025 14:34
Comment on lines -55 to -56
depends_on:
- l2_execution_engine
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can safely delete depends_on here since it's not working as expected anyway.

@dantaik dantaik requested a review from cyberhorsey July 27, 2025 15:36
- proposer

l2_execution_engine_taiko_reth:
image: ghcr.io/tatsujinlabs/taiko-reth:nightly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix a version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will release 0.1.1 soon, lets try this nightly tag with taikoxyz/taiko-mono#19783 in this PR at first.

EXECUTION_ENGINE_ENDPOINT: l2_execution_engine_taiko_reth
volumes:
- l2_execution_engine_data:/data/taiko-reth
- l2_execution_engine_data:/data/taiko-geth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we fixed the EXECUTION_ENGINE_ENDPOINT is reth, let's remove all geth related config.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't want to add another taiko_client_driver_taiko_reth service, how to remove this in volumes?

--ws
--ws.addr 0.0.0.0
--authrpc.addr 0.0.0.0
--chain mainnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we really ready to use it for mainnet? I haventnfollowed the taiko-geth progress thus far.

Copy link
Collaborator Author

@davidtaikocha davidtaikocha Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can p2p sync then produce the newly proposed batches with taikoxyz/taiko-mono#19783 now, so far all hashes matched, so it's ok to add this option to let users try imo.

@davidtaikocha davidtaikocha marked this pull request as draft October 14, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants