-
Notifications
You must be signed in to change notification settings - Fork 829
feat(repo): introduce taiko-reth as an alternative EE
#402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| depends_on: | ||
| - l2_execution_engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can safely delete depends_on here since it's not working as expected anyway.
| - proposer | ||
|
|
||
| l2_execution_engine_taiko_reth: | ||
| image: ghcr.io/tatsujinlabs/taiko-reth:nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we fix a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will release 0.1.1 soon, lets try this nightly tag with taikoxyz/taiko-mono#19783 in this PR at first.
| EXECUTION_ENGINE_ENDPOINT: l2_execution_engine_taiko_reth | ||
| volumes: | ||
| - l2_execution_engine_data:/data/taiko-reth | ||
| - l2_execution_engine_data:/data/taiko-geth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we fixed the EXECUTION_ENGINE_ENDPOINT is reth, let's remove all geth related config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't want to add another taiko_client_driver_taiko_reth service, how to remove this in volumes?
| --ws | ||
| --ws.addr 0.0.0.0 | ||
| --authrpc.addr 0.0.0.0 | ||
| --chain mainnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we really ready to use it for mainnet? I haventnfollowed the taiko-geth progress thus far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can p2p sync then produce the newly proposed batches with taikoxyz/taiko-mono#19783 now, so far all hashes matched, so it's ok to add this option to let users try imo.
Will be safer to merge when taikoxyz/taiko-mono#19783 is merged and released.